Skip to content

add ignore_in_venv to allow ignore in venv#10338

Draft
lucasiscovici wants to merge 2 commits intopython-poetry:mainfrom
lucasiscovici:patch-1
Draft

add ignore_in_venv to allow ignore in venv#10338
lucasiscovici wants to merge 2 commits intopython-poetry:mainfrom
lucasiscovici:patch-1

Conversation

@lucasiscovici
Copy link

@lucasiscovici lucasiscovici commented Apr 15, 2025 •
edited by sourcery-ai bot
Loading

Pull Request Check List

add the virtualenvs.ignore_in_venv config,to allow to ignore the check if inside venv (conda)

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Add configuration option to ignore virtualenv checks when inside a virtual environment

New Features:

  • Introduce virtualenvs.ignore_in_venv configuration to allow skipping virtualenv checks when inside a virtual environment

Enhancements:

  • Modify virtualenv detection logic to respect the new ignore_in_venv configuration option

@lucasiscovici
add ignore_in_venv to allow ignore in venv
6da7b68 
add the virtualenvs.ignore_in_venv config,to allow to ignore the check if inside venv (conda)
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 15, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new configuration option, virtualenvs.ignore_in_venv, which allows Poetry to bypass the check for virtual environments. This is useful in scenarios where the user wants to use a Conda environment but doesn't want Poetry to treat it as a virtual environment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a configuration option to ignore virtual environment checks.
  • Introduced virtualenvs.ignore_in_venv configuration option.
  • Modified the environment retrieval logic to consider the new configuration option.
 src/poetry/utils/env/env_manager.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lucasiscovici